Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fink button plugin #88

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

mcoughlin
Copy link
Contributor

This PR add the fink button as a SourcePlugin.

@mcoughlin mcoughlin requested a review from Theodlz March 8, 2024 21:49
@Theodlz
Copy link
Collaborator

Theodlz commented Mar 12, 2024

Thanks a lot @mcoughlin! Would you mind updating the copy of the config.defaults.yaml that is in the extension folder? We might want to just remove it entirely, but it requires some changes in the commands directory code. But right now, I can see that it shows the AddNewSource widget (on the dashboard) which we removed in SkyPortal.

@mcoughlin
Copy link
Contributor Author

@Theodlz Done.

Copy link
Collaborator

@Theodlz Theodlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit f847bc6 into grandma-collaboration:main Mar 13, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants